Re: [virtio-comment] [PATCH 5/6] VIRTIO-63: Make sure examples are marked clearly.

From
Cornelia Huck <>
Date
2014-03-03T13:20:17+00:00
ID
Thread
Re: [virtio-comment] [PATCH 5/6] VIRTIO-63: Make sure examples are marked clearly.
On Mon,  3 Mar 2014 15:31:32 +1030
Rusty Russell <> wrote:

> Signed-off-by: Rusty Russell <>
> ---
>  content.tex | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/content.tex b/content.tex
> index f3899b6..a11525b 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -212,8 +212,8 @@ result.
> 
>  The mechanism for bulk data transport on virtio devices is
>  pretentiously called a virtqueue. Each device can have zero or more
> -virtqueues: for example, the simplest network device has one for
> -transmit and one for receive.  Each queue has a 16-bit queue size
> +virtqueues\footnote{For example, the simplest network device has one for

I'd make that "has one _virtqueue_ for transmit" - this is probably
clearer as the footnote lacks the immediate context.

> +transmit and one for receive}.  Each queue has a 16-bit queue size
>  parameter, which sets the number of entries and implies the total size
>  of the queue.
> 

> @@ -1621,7 +1624,7 @@ or report device failure.
>  \paragraph{Virtqueue Configuration}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtqueue Configuration}
> 
>  As a device can have zero or more virtqueues for bulk data
> -transport (for example, the simplest network device has two), the driver
> +transport,\footnote{For example, the simplest network device has two} the driver

Similarily, I'd write "two virtqueues" here.

>  needs to configure them as part of the device-specific
>  configuration.
>