On Fri, 11 Mar 2016 16:45:48 +0100
Claudio Imbrenda <> wrote:
> From: Claudio Imbrenda <>
>
> Added missing endianness initializations in the vhost-vsock device.
>
> Signed-off-by: Claudio Imbrenda <>
> ---
> drivers/vhost/vsock.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index 2c5963c..9378f23 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -481,6 +481,8 @@ static int vhost_vsock_set_features(struct vhost_vsock *vsock, u64 features)
> vq = &vsock->vqs[i];
> mutex_lock(&vq->mutex);
> vq->acked_features = features;
> + vq->is_le = virtio_legacy_is_little_endian();
> + vhost_init_is_le(vq);
Hm... I'm not 100% sure that ->set_features() is the right place to
init this.
One thing I'm a bit puzzled about (I have not given vsock more than a
cursory glance, though) is why vsock does not seem to make use of
vq->private_data (and consequently, why we don't setup endianness when
something attaches there). I may be missing some very basics about
vsock, though :)
> mutex_unlock(&vq->mutex);
> }
> mutex_unlock(&vsock->dev.mutex);
