On Thu, Jul 19, 2018 at 2:29 PM, Sridhar Samudrala
<> wrote:
> VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net
> driver to act as a standby for another device with the same MAC address.
You should use another feature bit to represent the match-by-MAC
grouping. I think VIRTIO_NET_F_STANDBY is more of a failover concept
and shouldn't marry to any grouping mechanism. What you propose simply
kills off the possibility of introducing other grouping mechanisms
which don't rely on MAC address at all.
-Siwei
>
> Signed-off-by: Sridhar Samudrala <
> ---
> content.tex | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index be18234..010b6ee 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2525,6 +2525,9 @@ features.
>
> \item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)] Set MAC address through control
> channel.
> +
> +\item[VIRTIO_NET_F_STANDBY(62)] Driver acts as standby for another
> + device with the same MAC
> \end{description}
>
> \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device / Feature bits / Feature bit requirements}
> @@ -2636,6 +2639,13 @@ If the driver negotiates VIRTIO_NET_F_MTU, it MUST NOT transmit packets of
> size exceeding the value of \field{mtu} (plus low level ethernet header length)
> with \field{gso_type} NONE or ECN.
>
> +A driver SHOULD negotiate VIRTIO_NET_F_STANDBY feature if the device offers it.
> +
> +If the driver negotiates VIRTIO_NET_F_STANDBY, it should act as a standby for
> +another device with the same MAC address when available. The hypervisor can
> +hot-plug a primary device with same MAC address if the feature is successfully
> +negotiated with the driver.
> +
> \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout}
> \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout}
> When using the legacy interface, transitional devices and drivers
> --
> 2.14.4
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:
>