On Mon, May 11, 2020 at 5:44 AM David Hildenbrand <> wrote:
>
> On 11.05.20 14:38, Cornelia Huck wrote:
> > On Fri, 08 May 2020 10:16:14 -0700
> > Alexander Duyck <> wrote:
> >
> >> This patch set is meant to add documentation for balloon features that have
> >> been recently added to the Linux kernel[1,2] and that we are currently
> >> working on adding to QEMU[3].
> >>
> >> Changes since RFC:
> >> Incorporated suggestions from Cornelia Huck
> >> Fixed a few additional spelling errors
> >>
> >> [1]: https://lore.kernel.org/lkml/[email protected]/
> >> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc
> >> [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html
> >>
> >> ---
> >>
> >> Alexander Duyck (3):
> >> content: Document balloon feature free page hints
> >> content: Document balloon feature page poison
> >> content: Document balloon feature free page reporting
> >>
> >>
> >> content.tex | 248 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >> 1 file changed, 242 insertions(+), 6 deletions(-)
> >>
> >> --
> >>
> >
> > I think this has moved a lot into the right direction; but the patches
> > would really benefit from review by someone more familiar with the
> > balloon than me.
>
> On my list, will have a look this week.
>
> Minor nit I spotted: Patch #2 should not document things (e.g., how
> poisoning interacts with reported pages), before the free reporting
> feature is actually introduced in patch #3.
I'll tweak thinks a bit to work around that. The issue is that the
page poison feature was introduced before page reporting, however it
wasn't really put into use until page reporting was added.
> BTW: Thanks Alex for tackling this!
No problem. Thanks to you and Cornelia for taking the time to review this.
- Alex
