Next in thread → Next in month →

Re: [virtio] [PATCH v3] initialization: add extra device status handshake

From
Michael S. Tsirkin <>
Date
2013-10-08T12:11:17+00:00
ID
Thread
Re: [virtio] [PATCH v3] initialization: add extra device status handshake
On Tue, Oct 08, 2013 at 11:13:55AM +0200, Cornelia Huck wrote:
> On Tue, 8 Oct 2013 11:47:06 +0300
> "Michael S. Tsirkin" <> wrote:
> 
> > From: Rusty Russell <>
> > 
> > 2.2.1: FEATURES_OK.
> > 
> > Based on MST's ideas, but a bit simpler.  VIRTIO-30.
> >     
> > Signed-off-by: Rusty Russell <>
> > Signed-off-by: Michael S. Tsirkin <>
> > 
> > ---
> > 
> > This is just a repost of what Rusty sent, to make it easier
> > for people to review and vote on.
> > 
> > diff --git a/virtio-v1.0-wd01-part1-specification.txt b/virtio-v1.0-wd01-part1-specification.txt
> > index b4298bb..938abb8 100644
> > --- a/virtio-v1.0-wd01-part1-specification.txt
> > +++ b/virtio-v1.0-wd01-part1-specification.txt
> 
> > @@ -444,23 +447,49 @@ how to communicate with the specific device.
> > 
> >  3. The DRIVER status bit is set: we know how to drive the device.
> > 
> > -4. Device-specific setup, including reading the device feature
> > -  bits, discovery of virtqueues for the device, optional per-bus
> > -  setup, and reading and possibly writing the device's virtio
> > -  configuration space.
> > +4. Device feature bits are read, and the the subset of feature bits
> 
> Typo: s/the the/the/

Thanks!
I won't repost just for this since we have the rule that typos
can be fixed silently.

> > +   understood by the OS and driver is written to the device.
> > +
> > +5. The FEATURES_OK status bit is set.
> >
Next in thread → Next in month →