On Tue, 23 Jan 2018 02:01:06 +0200
"Michael S. Tsirkin" <> wrote:
> Update generic text to talk about available/used buffers, not rings.
> Move some split-ring specific text to the correct section.
>
> Signed-off-by: Michael S. Tsirkin <>
> ---
> content.tex
| 12 +++++
-------
> split-ring.tex | 4 ++++
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/content.tex b/content.tex
> index 5634c7d..0f7c2b9 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -4652,7 +4650,7 @@ Interface: Device Operation}
> When using the legacy interface, the driver SHOULD ignore the
> used length values.
> \begin{note}
> -Historically, devices put the total descriptor length,
> +Historically, devices put the total length,
> or the total length of device-writable buffers there,
> even when only part of the buffers were actually written.
This sentence reads a bit weirdly now. Total length of what?
> \end{note}
> diff --git a/split-ring.tex b/split-ring.tex
> index acdee7d..f976e45 100644
> --- a/split-ring.tex
> +++ b/split-ring.tex
> @@ -296,6 +296,10 @@ referred to this structure as vring_avail, and the constant as
> VRING_AVAIL_F_NO_INTERRUPT, but the layout and value were identical.
> \end{note}
>
> +\drivernormative{\subsubsection}{The Virtqueue Available Ring}{Basic Facilities of a Virtio Device / Virtqueues / The Virtqueue Available Ring}
> +A driver MUST NOT decrement the available \field{idx} on a virtqueue (ie.
> +there is no way to ``unexpose'' buffers).
Don't you need to reference that drivernormative section?
(It is a bit confusing with all those interim changes; maybe I should
only review the end result...)
> +
> \subsection{Virtqueue Interrupt Suppression}\label{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Interrupt Suppression}
>
> If the VIRTIO_F_EVENT_IDX feature bit is not negotiated,
