On 6/28/2023 8:22 AM, Parav Pandit wrote:
> Hi Lingshan Zhu,
>
> I have reviewed v4 version transport VQ a while back that consist of two main pieces.
>
> 1. some virtio device creation/destroy commands
> 2. virtio device feature and config space provisioning commands.
>
> Many of us are seeing the value of device provisioning commands with/without live migration.
>
> New virtio devices do not need to follow any existing of config space etc per say for real hw.
> There is some value in reusing software but it may not be the prime driving factor for brand new devices.
> This needs more discussion and not as_is done in the v4.
>
> So, if you are planning to revise your transport vq patches as admin commands, please split the series into two.
>
> a. device and config space provisioning SET/GET part.
Hi Parav
I agree it is good to unify the interface for SRIOV and SIOV. However
more discussion is required,
e.g., for a VF, will config its MSIX by admin vq(owned by host) conflict
with the MSIX cap.
Thanks,
Zhu Lingshan
> b. virtio child device creation aka SIOV/SF etc.
>
> First #a, followed by #b.
> Piece #a will be usable for SRIOV VFs + SF/SIOV devices and provides unified APIs across two different device group types.
>
> Parav
