Re: [office] table:filter-condition extension proposal

[Kohei Yoshida <kyoshida@novell.com>]

Hi Thomas,

On Sat, 2007-06-09 at 01:51 +0200, Thomas Zander wrote:
> On Friday 08 June 2007 21:20:29 Kohei Yoshida wrote:
> > I would like to propose an extension to the table:filter-condition
> > element to allow storage of multi-string filter data.  The details are
> > attached to this email
> 
> IMOHO the values look better as text nodes instead of attributes.
> so instead of:
>     <filter-set-item table:value="John Doe”/>
>     <filter-set-item table:value="Jane Doe”/>
> you have
>     <filter-set-item>John Doe”</filter-set-item>
>     <filter-set-item>Jane Doe”</filter-set-item>

The original motivation for proposing this format:

    <filter-set-item table:value="John Doe"/>

instead of the other format:

    <filter-set-item>John Doe</filter-set-item>

is to make it in line with the 'table:value' attribute of the current
table:filter-condition element, which is formatted like this:

  <filter-condition table:field-number=1 table:operator="="
          table:value="Doe"/>

Making the value an attribute will, IMHO, make it consistent with the
current filter-condition semantics, although in practice it would not
matter too much one way or the other.

What do others think of this?

Kohei