ISSUE-208: Problems with testcase JCA_7001

[David Booz <booz@us.ibm.com>]

http://www.osoa.org/jira/browse/JAVA-208

Dave Booz
STSM, BPM and SCA Architecture
Co-Chair OASIS SCA-Policy TC and SCA-J TC
"Distributed objects first, then world hunger"
Poughkeepsie, NY (845)-435-6093  or  8-295-6093
e-mail:booz@us.ibm.com


|------------>
| From:      |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |Mike Edwards <mike_edwards@uk.ibm.com>                                                                                                            |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To:        |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |"OASIS Java" <sca-j@lists.oasis-open.org>                                                                                                         |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date:      |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |08/18/2010 06:05 AM                                                                                                                               |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject:   |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |[sca-j] [NEW ISSUE] Problems with testcase JCA_7001                                                                                               |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|






Target:   sca-j-caa-1.1-testcases-cd01.odt

Description:

There are several faults with the artifacts of testcase JCA_7001:

1) JCA_7001_TestCase.java

Incorrect response string is declared:

          config.output[0]                  = "JCA_7001 request service1
operation1 invoked service2 operation1 invoked callback1 invoked other
callbacks null";

It should be as follows:

            config.output[0]                  = "JCA_7001 request service1
operation1 invoked " +
                                       "service2 operation3 invoked " +
                                       "service1 callback1 invoked " +
                                       "service1 callback1 invoked " +
                                       "other callbacks null";


2) Test_JCA_7001.composite

Incorrect descriptions of the components (editorial changes only)

3) MultipleCallbacksImpl.java

Inadequate description of the implementation (editorial change).

Incorrect response values from the operation3 and operation7 methods:

        /**
         * Service operation for Service3 which invokes an operation on the
callback Service3Callback
         */
        public String operation3(String input) {
                String callbackResult = callback3.callback1("callback");
                String callbackResult2 = setterCallback3.callback1(
"callback2");
                String otherCallbacks = "other callbacks null";
                if( callback7 != null || setterCallback7 != null )
otherCallbacks = "other callbacks also set";

                return serviceName + " operation1 invoked" + " " +
callbackResult + " " + callbackResult2 + " " + otherCallbacks;
        }

        /**
         * Service operation for Service7 which invokes an operation on the
callback Service7Callback
         */
        public String operation7(String input) {
                String callbackResult = callback7.service7Callback1(
"callback");
                String callbackResult2 = setterCallback7.service7Callback1(
"callback2");
                String otherCallbacks = "other callbacks null";
                if( callback3 != null || setterCallback3 != null )
otherCallbacks = "other callbacks also set";

                return serviceName + " operation1 invoked" + " " +
callbackResult + " " + callbackResult2 + " " + otherCallbacks;
        }

These methods should include their method names in the response strings,
not the name "operation1":

        /**
         * Service operation for Service3 which invokes an operation on the
callback Service3Callback
         */
        public String operation3(String input) {
                String callbackResult = callback3.callback1("callback");
                String callbackResult2 = setterCallback3.callback1(
"callback2");
                String otherCallbacks = "other callbacks null";
                if( callback7 != null || setterCallback7 != null )
otherCallbacks = "other callbacks also set";

                return serviceName + " operation3 invoked" + " " +
callbackResult + " " + callbackResult2 + " " + otherCallbacks;
        }

        /**
         * Service operation for Service7 which invokes an operation on the
callback Service7Callback
         */
        public String operation7(String input) {
                String callbackResult = callback7.service7Callback1(
"callback");
                String callbackResult2 = setterCallback7.service7Callback1(
"callback2");
                String otherCallbacks = "other callbacks null";
                if( callback3 != null || setterCallback3 != null )
otherCallbacks = "other callbacks also set";

                return serviceName + " operation7 invoked" + " " +
callbackResult + " " + callbackResult2 + " " + otherCallbacks;
        }

Proposal:

1) JCA_7001_TestCase.java
Change the response string to the second form shown above

2) Test_JCA_7001.composite

Add the following descriptive paragraph:

" This test is based on one component invoking a bidirectional service on a
second component, where that second
 component has two different bidirectional services.  The test checks for
both Field and Setter injection of the
 callback for the first service - it also checks to see that the Fields &
Setters for the second (not invoked)
 service are set to null."

3) MultipleCallbacksImpl.java

Change the return strings for the 2 methods to the second set of values
shown above.



Yours,  Mike.

Strategist - Emerging Technologies, SCA & SDO.
Co Chair OASIS SCA Assembly TC.
IBM Hursley Park, Mail Point 146, Winchester, SO21 2JN, Great Britain.
Phone & FAX: +44-1962-818014    Mobile: +44-7802-467431
Email:  mike_edwards@uk.ibm.com






Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU