Re: [virtio-comment] [PATCH 3/5] virtio-blk spec: document topology fields

[Rusty Russell <rusty@au1.ibm.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:
> This completes the changes from yesterday.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

This one looks like this:

commit c1bf046a7b9750d2ce555e2e4e91f67c9c6b7d87
Author: Rusty Russell <rusty@au1.ibm.com>
Date:   Wed Aug 21 15:43:24 2013 +0930

    2.5.2.3:  document topology fields
    
    From: Paolo Bonzini <pbonzini@redhat.com>
    
    This completes the changes from yesterday.
    
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    
    See:https://lists.oasis-open.org/archives/virtio-comment/201308/msg00030.html
    Signed-off-by: Rusty Russell <rusty@au1.ibm.com>

diff --git a/virtio-v1.0-wd01-part1-specification.txt b/virtio-v1.0-wd01-part1-specification.txt
index 495dd98..2cf0645 100644
--- a/virtio-v1.0-wd01-part1-specification.txt
+++ b/virtio-v1.0-wd01-part1-specification.txt
@@ -1565,9 +1565,13 @@ device except where noted.
 		} geometry;
 		le32 blk_size;
 		struct virtio_blk_topology {
+			// # of logical blocks per physical block (log2)
 			u8 physical_block_exp;
+			// offset of first aligned logical block
 			u8 alignment_offset;
+			// suggested minimum I/O size in blocks
 			u16 min_io_size;
+			// optimal (suggested maximum) I/O size in blocks
 			u32 opt_io_size;
 		} topology;
 		u8 writeback;