Re: [virtio-comment] comment on pci section

[Rusty Russell <rusty@au1.ibm.com>]

"Michael S. Tsirkin" <mst@redhat.com> writes:
> Two comments received from a co-worker:
>
> 3.1 "The device MUST NOT consume buffers before DRIVER_OK ..." - I
> personally
> would like to see also something like:  "device must not generate
> interrupts if
> DRIVER_OK is not set” to better handle power management transitions.

That addition seems to make sense, but I don't understand the reference
to power management transitions?

> 4.1.3.1.1.
> Must clarify that all devices MUST support all cfg_type values 1-5.
> This way BIOS can limit type 5 exclusively and drivers don't
> need to add support for type 5.

The word "support" here is unclear to me.  Are you saying that a device
MUST offer a VIRTIO_PCI_CAP_PCI_CFG value?  Something like:

        Drivers MUST offer at least one capability of each type.

Thanks,
Rusty.