Re: RE: [virtio-comment] RE: RE: [PATCH v15] virtio-net: support device stats

[Xuan Zhuo <xuanzhuo@linux.alibaba.com>]

On Tue, 29 Aug 2023 10:58:40 +0000, Parav Pandit <parav@nvidia.com> wrote:
>
> > From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > Sent: Tuesday, August 29, 2023 12:48 PM
> >
> > For this line:
> >  "If the reply header structure and actual stats are split properly, it will be easy
> >   to add the query by the owner device."
> >
> > So for the header structure, is there some specific requirements?
>
> TLV type, length, is only two fields needed and to align to 64-bit.
> struct virtio_element_type {
> 	u16 type;
> 	u16 rsvd;
> 	u32 length;
> };
>
> Above generic type if defined, that we can possibly use across many virtio devices.


I see.

So I wonder, should we be thinking about this now. When will we try to get
statistics via aq. If we try to do this, the request data may also have to use a
uniform format.

Thanks.