Re: [virtio-comment] [PATCH 1/1] ccw: ccw payload description

[Rusty Russell <rusty@au1.ibm.com>]

Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> On Thu, 06 Feb 2014 12:53:22 +1030
> Rusty Russell <rusty@au1.ibm.com> wrote:
>
>> Cornelia Huck <cornelia.huck@de.ibm.com> writes:
>> > On Sun, 2 Feb 2014 18:27:26 +0200
>> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> >
>> >> On Fri, Jan 31, 2014 at 03:25:31PM +1030, Rusty Russell wrote:
>> >> Sounds good, let's do that. And let's add a comment
>> >> where we define leXX.
>> >
>> > https://lists.oasis-open.org/archives/virtio/201401/msg00089.html adds
>> > definitions for leXX types, among other things.
>> 
>> Yes, I assume that will pass at the next meeting, then we can extend
>> it.  It's actually hard to do in a meaningful way.  Here's my attempt:
>> 
>> \item[le16, le32, le64] An unsigend integer of the specified length in bits,
>> in little-endian byte order.  (Those implementing legacy compatibility
>> should be aware that most little-endian fields were native-endian in
>> earlier drafts: see \ref{sec:Basic Facilities of a Virtio Device /
>> Feature Bits / Legacy Interface: A Note on transitions from earlier
>> drafts}).
>> 
>> Thoughts?
>> Rusty.
>> 
>> 
>
> Not sure whether we want to annotate the definition. I'd expect a hint
> like that more in the general section.

Yes, perhaps with the /* WARNING */ comments and the sections on
legacy, this is overkill.

Let's drop this unless someone thinks it's really necessary.

Thanks,
Rusty.