Re: [virtio] [PATCH] virtio-net: fix inconsistent legacy header size

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Tue, 16 Feb 2016 11:22:23 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Current text says:
> 	The legacy driver only presented num_buffers in the struct
> 	virtio_net_hdr when VIRTIO_NET_F_MRG_RXBUF was not negotiated;
> 
> Should be:
> 	"... was negotiated ..." instead of "... was not negotiated ..."
> 
> To be consistent with the following:
> 	without that feature the structure was 2 bytes shorter.
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> I'm checking this in under the trivial corrections rule.
> 
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/content.tex b/content.tex
> index 941daa6..5b8a22c 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -3268,7 +3268,7 @@ according to the native endian of the guest rather than
>  (necessarily when not using the legacy interface) little-endian.
> 
>  The legacy driver only presented \field{num_buffers} in the struct virtio_net_hdr
> -when VIRTIO_NET_F_MRG_RXBUF was not negotiated; without that feature the
> +when VIRTIO_NET_F_MRG_RXBUF was negotiated; without that feature the
>  structure was 2 bytes shorter.
> 
>  When using the legacy interface, the driver SHOULD ignore the

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>