Re: [virtio] [PATCH] virtio-ring.h -> virtio-queue.h

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Tue, 16 Feb 2016 12:15:22 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Feb 16, 2016 at 10:54:07AM +0100, Cornelia Huck wrote:
> > On Tue, 16 Feb 2016 11:35:53 +0200
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > 
> > > Since vring* and VRING* have been replaced with virtq* and VIRTQ*
> > > respectively, rename the header virtio_ring.h to virtio_queue.h.
> > > 
> > > Suggested-by: Kevin Lo <kevlo@kevlo.org>
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > > 
> > >  virtio-ring.h => virtio-queue.h | 0
> > >  cl-cs03.tex                     | 2 +-
> > >  content.tex                     | 4 ++--
> > >  headerfile.tex                  | 4 ++--
> > >  makezip.sh                      | 4 ++--
> > >  specvars.tex                    | 2 +-
> > >  6 files changed, 8 insertions(+), 8 deletions(-)
> > >  rename virtio-ring.h => virtio-queue.h (100%)
> > > 
> > > diff --git a/virtio-ring.h b/virtio-queue.h
> > > similarity index 100%
> > > rename from virtio-ring.h
> > > rename to virtio-queue.h
> > > diff --git a/cl-cs03.tex b/cl-cs03.tex
> > > index ab26d64..72925ca 100644
> > > --- a/cl-cs03.tex
> > > +++ b/cl-cs03.tex
> > > @@ -43,7 +43,7 @@ virtio-ring: comment fixup
> > >  virtio_ring.h included with spec has this text:
> > >  /* Support for avail_idx and used_idx fields */
> > >  it should really refer to avail_event and used_event.
> > > -See Appendix \ref{sec:virtio-ring.h}.
> > > +See Appendix \ref{sec:virtio-queue.h}.
> > 
> > This one reads slightly confusing now... maybe we should avoid
> > referencing stuff that may be renamed later in the change log?
> 
> Confusing in Tex maybe but in the result it just says "Appendix A".

Yep. Most people won't look at the Tex anyway... I just stumbled over
it.

> 
> > >   } \\
> > >  \hline
> > >  486 & 15 Mar 2015 & Jason Wang & {VIRTIO-136:
> > 
> > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>