Re: [virtio-dev] [PATCH v11] virtio-net: add Max MTU configuration field

[Aaron Conole <aconole@redhat.com>]

Cornelia Huck <cornelia.huck@de.ibm.com> writes:

> On Mon, 19 Sep 2016 11:10:26 -0400
> Aaron Conole <aconole@redhat.com> wrote:
>
>> @@ -3165,6 +3192,16 @@ If the driver does not negotiate the
>> VIRTIO_NET_F_STATUS feature, it SHOULD
>>  assume the link is active, otherwise it SHOULD read the link status from
>>  the bottom bit of \field{status}.
>> 
>> +A driver SHOULD negotiate VIRTIO_NET_F_MTU if the device offers it.
>> +
>> +If the driver negotiates VIRTIO_NET_F_MTU, it MUST supply enough receive
>> +buffers of size \field{mtu} (plus low level ethernet header length) to be
>> +able to receive at least one receive packet with \field{gso_type} NONE or ECN.
>> +
>> +If the driver negotiates VIRTIO_NET_F_MTU, it MUST NOT transmit packets of
>> +size exceeding the value of \field{mtu} (plus low level ethernet header length)
>> +with \field{gso_type} NONE or ECN
>
> Missing period.

D'oh!

Michael,
  Is this something that requires a new spin of the patch to
correct?  If so, I'll add Cornelia's ACK and repost today.

>> +
>>  \subsubsection{Legacy Interface: Device configuration
>> layout}\label{sec:Device Types / Network Device / Device
>> configuration layout / Legacy Interface: Device configuration
>> layout}
>>  \label{sec:Device Types / Block Device / Feature bits / Device
>> configuration layout / Legacy Interface: Device configuration
>> layout}
>>  When using the legacy interface, transitional devices and drivers
>
> Otherwise,
>
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
>