Re: [virtio] [OASIS Issue Tracker] Created: (VIRTIO-17) Remove VIRTIO_NET_F_GSO

[Rusty Russell <rusty@au1.ibm.com>]

OASIS Issues Tracker <workgroup_mailer@lists.oasis-open.org> writes:
> Remove VIRTIO_NET_F_GSO
> -----------------------
>
>                  Key: VIRTIO-17
>                  URL: http://tools.oasis-open.org/issues/browse/VIRTIO-17
>              Project: OASIS Virtual I/O Device (VIRTIO) TC
>           Issue Type: Improvement
>             Reporter: Rusty Russell
>
>
> This predated actual implementation, which needed more specific bits.

Interestingly, it's accepted by the current virtio-net driver, though
it's not offered by any device I know of.

commit 23caf2832c60c81ad00991dde88ef2f63ab48803
Author: Rusty Russell <rusty@au1.ibm.com>
Date:   Wed Sep 11 13:17:47 2013 +0930

    net: remove VIRTIO_NET_F_GSO
    
    As per https://tools.oasis-open.org/issues/browse/VIRTIO-17
    
    Signed-off-by: Rusty Russell <rusty@au1.ibm.com>

diff --git a/virtio-v1.0-wd01-part1-specification.txt b/virtio-v1.0-wd01-part1-specification.txt
index 16d2991..5350910 100644
--- a/virtio-v1.0-wd01-part1-specification.txt
+++ b/virtio-v1.0-wd01-part1-specification.txt
@@ -1200,9 +1200,6 @@ features.
 
   VIRTIO_NET_F_MAC (5) Device has given MAC address.
 
-  VIRTIO_NET_F_GSO (6) (Deprecated) device handles packets with
-    any GSO type.[12]
-
   VIRTIO_NET_F_GUEST_TSO4 (7) Guest can receive TSOv4.
 
   VIRTIO_NET_F_GUEST_TSO6 (8) Guest can receive TSOv6.
@@ -1248,6 +1245,15 @@ features.
 		u16 status;
 	};
 
+2.4.1.3. Legacy Interface: Feature bits
+--------------------
+VIRTIO_NET_F_GSO (6) Device handles packets with any GSO type.
+
+This was supposed to indicate segmentation offload support, but
+upon further investigation it became clear that multiple bits
+were required.
+
+
 2.4.1.4. Device Initialization
 -----------------------------
 
@@ -2909,10 +2915,6 @@ of this expected condition is necessary.
 mistakes!
 
 
-[12] It was supposed to indicate segmentation offload support, but
-upon further investigation it became clear that multiple bits
-were required.
-
 [13] ie. VIRTIO_NET_F_HOST_TSO* and VIRTIO_NET_F_HOST_UFO are
 dependent on VIRTIO_NET_F_CSUM; a dvice which offers the offload
 features must offer the checksum feature, and a driver which