virtio — archive

[Michael S. Tsirkin]

On Thu, Jun 26, 2014 at 10:52:43AM +0100, Pawel Moll wrote: > On Wed, 2014-06-25 at 19:29 +0100, Michael S. Tsirkin wrote: > > On Wed, Jun 25, 2014 at 01:54:24PM +0100, Pawel Moll wrote: > > > On Wed, 2014-06-25 at 13:24 +0100, Michael S. Tsirkin wrote: > > > > OK I will try this but I note this gives us back > > > > DIFaddbegin/DIFaddend. > > > > You are saying with egingroup/endgroup color stack > > > > overflow errors go away? > > > > > > Yes. Commands like color apply to a single group, usually marked with > > > curly brackets {xxx}, with group and egingroup (there's some subtle > > > difference I don't really understand; enough to say that group didn't > > > work for me ;-). I have no idea why are they pushed to a stack, if there > > > seem to be no pop operation, but just enclosing a change in a separate > > > group seems enough. That's what my first proposal did (notice extra {} > > > in DIFaddtex), but as you pointed out it missed some bits. > > > > > > > How about footnotes? > > > > Is there a way to fix them without an external script? > > > > Would be nice if the footnote mark was also crossed-out ... > > > > > > Right, my first version did it, then I forgot to check it. Anyway, this > > > (slightly suboptimal, but I couldn't care less) should cover all cases > > > (I see footnotes on page 59 coloured): > > > > Hmm fails build for me > > [46] > > Chapter 5. > > ! Missing endgroup inserted. > > <inserted text> > > endgroup > > l.3613 DIFaddbegin DIFadd{18 }& > > DIFadd{Input device }\ > > Have you added > > --config "FLOATENV=(?:figure table tabular plate)[wd*@]*" > > to the latexdiff command line? (I mentioned that in one of the mails > before. Hmm it still fails for me: ! LaTeX Error: Missing egin{document}. See the LaTeX manual or LaTeX Companion for explanation. Type H <return> for immediate help. ... l.334 providecommand {DIFaddtex}[1]{ exorpdfstring{DIFaddtex{#1}}{#1}} %D... > > > 8< ---------------------- > > > %DIF FONTSTRIKE PREAMBLE > > > RequirePackage[normalem]{ulem} > > > providecommand{DIFaddtex}[1]{color{blue}sf #1} > > > providecommand{DIFdeltex}[1]{color{red}footnotesize sout{#1}} > > > %DIF END FONTSTRIKE PREAMBLE > > > %DIF COLOR PREAMBLE > > > RequirePackage{color} > > > providecommand{DIFaddbegin}{egingroupcolor{blue}} > > > providecommand{DIFaddend}{endgroup} > > > providecommand{DIFdelbegin}{egingroup > > > color{red}hypersetup{linkcolor=red,urlcolor=red}} > > > providecommand{DIFdelend}{hypersetup{linkcolor=green,urlcolor=green}endgroup} > > > %DIF END COLOR PREAMBLE > > > % Standard DIFadd and DIFdel are redefined as DIFaddtex and > > > DIFdeltex > > > % when hyperref package is included. > > > %DIF HYPERREF PREAMBLE > > > providecommand{DIFadd}[1]{ exorpdfstring{DIFaddtex{#1}}{#1}} > > > providecommand{DIFdel}[1]{ exorpdfstring{DIFdeltex{#1}}{}} > > > %DIF END HYPERREF PACKAGE > > > > this should not be needed: latexdiff adds it itself. > > And we can make it DIFadd/DIFdel above - it will rename them > > to DIFaddtex/DIFdeltex. > > Right? > > I'm not sure which bit do you refer to? Anyway, only with this version > I've managed to get colors in the normal text flow, in the tables and in > the footnotes. > > On Thu, 2014-06-26 at 07:52 +0100, Michael S. Tsirkin wrote: > > The one on page 78 does not seem coloured. > > It's fine here - see attached. > > Pawel