virtio — archive

[Michael S. Tsirkin <pawel.moll@arm.com>]

On Tue, Jul 22, 2014 at 08:15:23AM +0100, Pawel Moll wrote: > Fix minor typos as reported in ARM's feedback. > > Signed-off-by: Pawel Moll <pawel.moll@arm.com> This fixes VIRTIO-101 right? Pls note in commit log. I agree this can be checked in immediately. > --- > content.tex 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > Missed the "MUST not" one... > > diff --git a/content.tex b/content.tex > index 2f09419..e87f018 100644 > --- a/content.tex > +++ b/content.tex > @@ -168,7 +168,7 @@ space. > > drivernormative{subsection}{Device Configuration Space}{Basic Facilities of a Virtio Device / Device Configuration Space} > Drivers MUST NOT assume reads from > -fields greater than 32 bits wide are atomic, nor reads from > +fields greater than 32 bits wide are atomic, nor are reads from > multiple fields: drivers SHOULD read device configuration space fields like so: > > egin{lstlisting} > @@ -216,7 +216,7 @@ The correct endian-ness is documented for each device. > > Legacy devices did not have a configuration generation field, thus are > susceptible to race conditions if configuration is updated. This > -effects the block field{capacity} (see ef{sec:Device Types / > +affects the block field{capacity} (see ef{sec:Device Types / > Block Device / Feature bits / Device configuration layout}) and > network field{mac} (see ef{sec:Device Types / Network Device / > Device configuration layout}) fields; > @@ -684,7 +684,7 @@ Device Initialization / Read feature bits} Read device feature bits, and write t > understood by the OS and driver to the device. During this step the > driver MAY read (but MUST NOT write) the device-specific configuration fields to check that it can support the device before accepting it. > > -itemlabel{itm:General Initialization And Device Operation / Device Initialization / Set FEATURES-OK} Set the FEATURES_OK status bit. The driver MUST not accept > +itemlabel{itm:General Initialization And Device Operation / Device Initialization / Set FEATURES-OK} Set the FEATURES_OK status bit. The driver MUST NOT accept > new feature bits after this step. > > itemlabel{itm:General Initialization And Device Operation / Device Initialization / Re-read FEATURES-OK} Re-read field{device status} to ensure the FEATURES_OK bit is still > @@ -3642,7 +3642,7 @@ compartibility. > > drivernormative{subparagraph}{Setting Offloads State}{Device Types / Network Device / Device Operation / Control Virtqueue / Offloads State Configuration / Setting Offloads State} > > -A driver MUST NOT enable a offload for which the appropriate feature > +A driver MUST NOT enable an offload for which the appropriate feature > has not been negotiated. > > subparagraph{Legacy Interface: Setting Offloads State}label{sec:Device Types / Network Device / Device Operation / Control Virtqueue / Offloads State Configuration / Setting Offloads State / Legacy Interface: Setting Offloads State} > -- > 1.9.1 > > > --------------------------------------------------------------------- > To unsubscribe from this mail list, you must leave the OASIS TC that > generates this mail. Follow this link to all your TCs in OASIS at: > https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php