virtio — archive

RE: [PATCH v10 03/10] admin: introduce group administration commands

From: Parav Pandit
To: [email protected]
Date: Thu, 02 Mar 2023 18:41:00 -0000

> From: Michael S. Tsirkin <[email protected]> > Sent: Thursday, March 2, 2023 8:05 AM > +When field{status} is VIRTIO_ADMIN_STATUS_OK, field{status_qialifier} > +is reserved and set to zero by the device. > + s/status_qialifier/status_qualifier Missed from v10 of Feb. > +When field{status} is VIRTIO_ADMIN_STATUS_EINVAL, the following table > +describes possible field{status_qialifier} values: s/status_qialifier/status_qualifier Can you please add other useful error codes in addition to the EINVAL? Few that we are needed EAGAIN, ENOMEM, EBUSY, ENODEV. And with that, VIRTIO_ADMIN_STATUS_Q_INVALID_MEMBER moves under ENODEV error code. > +egin{tabular}{ l l l } > +hline > +Status & Name & Description \ > +hline hline > +0x00 & VIRTIO_ADMIN_STATUS_Q_INVALID_COMMAND & command > error: no additional information \ > +hline > +0x01 & VIRTIO_ADMIN_STATUS_Q_INVALID_OPCODE & unsupported or > invalid field{opcode} \ > +hline > +0x02 & VIRTIO_ADMIN_STATUS_Q_INVALID_FIELD & unsupported or > invalid field within field{command_specific_data} \ > +hline > +0x03 & VIRTIO_ADMIN_STATUS_Q_INVALID_GROUP & unsupported or > invalid field{group_type} \ > +hline > +0x04 & VIRTIO_ADMIN_STATUS_Q_INVALID_MEMBER & unsupported or > invalid field{group_member_id} \ > +hline > +0x05-0xFFFF & - & reserved for future use \ > +hline > +end{tabular}