virtio — archive
[Date Prev]
| [Thread Prev]
| [Thread Next]
| [Date Next]
— [Date Index]
| [Thread Index]
| [Month Index]
| [List Home]
RE: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved
On Thu, Mar 02, 2023 at 06:40:55PM +0000, Parav Pandit wrote:
>
>
>
From: Michael S. Tsirkin <[email protected]>
>
> Sent: Thursday, March 2, 2023 8:05 AM
> >
>
> Adding relevant registers needs more work and it's not clear what the use-case
>
> will be as currently only the PCI transport is supported. But let's keep the door
>
> open on this.
>
> We already say it's reserved in a central place, but it does not hurt to remind
>
> implementers to mask it.
> >
>
> Signed-off-by: Michael S. Tsirkin <[email protected]>
>
> Did you miss reviewed-by from [1] or this is an old series reposted?
> [1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00242.html
>
> I will wait for your response before reviewing more, as I am confused now between missing items of v10 of Feb and March.
There was such a huge flamewar around error codes I probably just missed
some useful comments among the noise.
> Can you please have the per-patch change log? I learnt and practice that from netdev community.
> It has been very useful to have effective reviews (especially when series is long).
Can't promise really I will need to look for tooling for that.
Unlikely to happen with this patch.
I'm not asking others to do it either.
--
MST
[Date Prev]
| [Thread Prev]
| [Thread Next]
| [Date Next]
— [Date Index]
| [Thread Index]
| [Month Index]
| [List Home]