virtio — archive

RE: [PATCH v10 03/10] admin: introduce group administration commands

From: Parav Pandit <[email protected]>
To: [email protected]
Date: Tue, 07 Mar 2023 18:27:00 -0000

> From: Michael S. Tsirkin <[email protected]> > Sent: Thursday, March 2, 2023 6:47 PM > > Can you please add other useful error codes in addition to the EINVAL? > > Few that we are needed EAGAIN, ENOMEM, EBUSY, ENODEV. > > We'll add them when there's a use-case. Errno.h is self-explanatory for the use case. A device may want the driver to retry the command as it is busy. > > > And with that, VIRTIO_ADMIN_STATUS_Q_INVALID_MEMBER moves under > ENODEV error code. > > > No I think that belongs in in EINVAL - command is malformed. Command is not malformed. The command prepared is correct, the VF number in the well-formed command which has an invalid VF device number. > ENODEV is more "The wrong type of device was given to a function that > expects a particular sort of device." > Yes. Hence the ENODEV when the VF device is accessed is not valid.