virtio — archive

[PATCH] virtio-net: clarify error handling for coalescing

From: Michael S. Tsirkin <[email protected]>
To: [email protected]
Date: Mon, 29 Jan 2024 16:27:00 -0000

On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: > On Wed, Jan 24 2024, "Michael S. Tsirkin" <[email protected]> wrote: > > > This is not a huge deal since it's a SHOULD anyway, > > so make the new requirement SHOULD too. > > > > Signed-off-by: Michael S. Tsirkin <[email protected]> > > --- > > device-types/net/description.tex | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/device-types/net/description.tex b/device-types/net/description.tex > > index aff5e08..d1d25fe 100644 > > --- a/device-types/net/description.tex > > +++ b/device-types/net/description.tex > > @@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi > > > > The device MUST ignore \field{reserved}. > > > > -The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters. > > +The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and > > +VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if > > +it was not able to change coalescing parameters. In this case, > > Hm, if we explicitly specify "coalescing parameters" here, should we add > it below as well? (We probably should keep the "the".) maybe "some of the" and in the next sentence "all of the". so it's atomic: all or nothing. > > +the parameters SHOULD remain unchanged, for all VQs. > > + > > > > The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.