Lists Home |
Date Index |
- From: "Don Park" <firstname.lastname@example.org>
- To: "David Megginson" <email@example.com>, "xml-dev Mailing List" <firstname.lastname@example.org>
- Date: Tue, 16 Dec 1997 20:44:22 -0800
Looks good in general. I have only a few comments and a couple of
<comment type="renaming familiar pattern">
I would rename XmlApplication and XmlProcessor to XmlConsumer and
XmlProducer. It is just matter of current Java API tradition.
Additionally, I would write a helper class XmlFilter.
Producer/Filter/Consumer arrangement is a well known design pattern and it
would be confusing to rename it.
I would rename startProlog, endProlog, and processingInstruction to
something more friendly. To most beginner XML programmers, they wouldn't
know what PI is nor would they care. I would group all "abnormal" tags
(with the exception of comments) as special elements and have a separate
pair of start/end for them. I would add a separate method for comments
text. Renaming characters() to content() might make it more clear to
programmers about what the method does.
I would also rename xetPublicId and xetSystemId to xetPublicID and
xetSystemID. I usually change acronyms when they are used as prefix (XML to
Xml) but not when they are used to postfix a name. It tend to look more
Would entities be resolved by XmlProcessor er, XmlProducers?
xml-dev: A list for W3C XML Developers. To post, mailto:email@example.com
Archived as: http://www.lists.ic.ac.uk/hypermail/xml-dev/
To (un)subscribe, mailto:firstname.lastname@example.org the following message;
To subscribe to the digests, mailto:email@example.com the following message;
List coordinator, Henry Rzepa (mailto:firstname.lastname@example.org)