Re: [virtio-comment] [ERRATUM?] 5.5.6.3 Memory Statistics: 6 -> 10 byte

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, May 23, 2019 at 02:51:48PM +0200, Philipp Hahn wrote:
> Hello,
> 
> quoting
> <https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-2930003>:
> 
> > Within the buffer, statistics are an array of 6-byte entries. 
>                                                 ^
> > Each statistic consists of a 16 bit tag and a 64 bit value.
> ...
> > struct virtio_balloon_stat { 
> ...
> >         le16 tag; 
> >         le64 val; 
> > } __attribute__((packed));
> 
> If my calculation is right that is a (16 + 64) = 80 bits which is a
> 10-byte sized entry - not 6-byte.
> 
> Philipp


Agreed. Want to open a github issue?

> -- 
> Philipp Hahn
> Open Source Software Engineer
> 
> Univention GmbH
> be open.
> Mary-Somerville-Str. 1
> D-28359 Bremen
> Tel.: +49 421 22232-0
> Fax : +49 421 22232-99
> hahn@univention.de
> 
> http://www.univention.de/
> Geschäftsführer: Peter H. Ganten
> HRB 20755 Amtsgericht Bremen
> Steuer-Nr.: 71-597-02876
> 
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
> 
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
> 
> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> List help: virtio-comment-help@lists.oasis-open.org
> List archive: https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee: https://www.oasis-open.org/committees/virtio/
> Join OASIS: https://www.oasis-open.org/join/