Re: [virtio-comment] [ERRATUM?] 5.5.6.3 Memory Statistics: 6 -> 10 byte

[Philipp Hahn <hahn@univention.de>]

Hello Michael,

Am 24.05.19 um 05:39 schrieb Michael S. Tsirkin:
> On Thu, May 23, 2019 at 02:51:48PM +0200, Philipp Hahn wrote:
>> quoting
>> <https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-2930003>:
>>
>>> Within the buffer, statistics are an array of 6-byte entries. 
>>                                                 ^
>>> Each statistic consists of a 16 bit tag and a 64 bit value.
>> ...
>>> struct virtio_balloon_stat { 
>> ...
>>>         le16 tag; 
>>>         le64 val; 
>>> } __attribute__((packed));
>>
>> If my calculation is right that is a (16 + 64) = 80 bits which is a
>> 10-byte sized entry - not 6-byte.
> 
> 
> Agreed. Want to open a github issue?

Sure, here it is: <https://github.com/oasis-tcs/virtio-spec/issues/45>

Patch attached and also available from
<https://github.com/univention/virtio-spec/commit/609dbbbe71fc9143c2849d2c9c2d481ec178ce30>

Philipp