[
Lists Home |
Date Index |
Thread Index
]
>I'm a C programmer at heart. You see a Java object, I see a pointer...
I see far too many NullPointerExceptions!
>> 05> if (next.getNodeType() == Node.ELEMENT_NODE) {
>> 06> getElements(e,l).add(e);
>> 07> }
>
>Well, this won't work either (it should be adding next, not e),
>but I have the excuse of having written the code in my phone's
>email client.
I put a milk carton in the oven the other day...
>This will work (and is shorter, although I added some linebreaks
>for style purposes):
>
> public List getElements(Document d) {
> return getElements(
> d.getDocumentElement(),
> new ArrayList(Collections.singleton(d.getDocumentElement()))
> );
> }
>
> private final List getElements(Node e, final List l) {
> for (Node next = e.getFirstChild();next != null;next =
>next.getNextSibling()) {
> if (next.getNodeType() == Node.ELEMENT_NODE) {
> getElements(next,l).add(next);
> }
> }
> return l;
> }
>
>That said, I'm assuming that we can do a Riserva from 1997 or 1998?
Given the stylish use of the singleton, I suppose so (sheesh! you're
probably talking 4 or 5 euro).
Cheers,
Danny.
|
